-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Sprockets 3.0 #217
Conversation
Thanks @alexkravets. Where does this stand with respect to #216 (comment)? |
@jfirebaugh no backward compatibility for |
Ok, I can't accept this PR as-is then. Konacha needs to maintain compatibility with Rails 4.1. |
@jfirebaugh do you want me to bump version? |
@alexkravets Which version are you referring to? |
@jfirebaugh we can bump konacha major version, so for |
No -- I want to maintain Rails 4.1 and sprockets 2 support:
|
@jfirebaugh we have no interest to do that. |
Ok, sorry but I can't accept this PR in that case. |
No problem. |
@alexkravets I hope you don't mind but I've made a patch that adds the conditionals for sprockets 3 API and undo konacha.gemspec modifications: https://gist.github.com/rafamanzo/4deafb6546ffd350a689 I hope you can apply it, so @jfirebaugh can reopen and accept this. It you are really not interested on it, do you mind if a open a new PR with such changes? Thanks! |
@rafamanzo new pull request has been created: #219 — with your patch applied, thanks! @jfirebaugh please take a look, now this should be good to go! |
No description provided.